Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression of industry per-capita Value Added #438

Conversation

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented Oct 26, 2023

A bug in the industry Value Added regression lead to wrong demand numbers for Other Industry, from #408/v0.165.0 onwards. Affected are all input data revisions after July 13

rev6.542APT-2023-07-16           mrremind  0.164.2
rev6.544                         mrremind  0.166.0
rev6.542APT-2023-08-06           mrremind  0.167.2
rev6.51campaigners               mrremind  0.168.0
rev6.542APT-2023-09-03           mrremind  0.168.1
rev6.542APT-2023-09-10           mrremind  0.168.2
rev6.542APT-2023-09-17           mrremind  0.169.3
rev6.542APT-2023-09-24           mrremind  0.169.4
rev6.543trspARIADNEchanges       mrremind  0.169.4
rev6.542APT-2023-10-01           mrremind  0.169.4
rev6.542APT-2023-10-08           mrremind  0.169.4
rev6.544trspARIADNEchanges       mrremind  0.169.4
rev6.545trspARIADNEchanges       mrremind  0.169.4
rev6.542APT-2023-10-15           mrremind  0.169.4
rev6.55ARIADNEtrsp               mrremind  0.169.4
rev6.56-test_SSP5_industry       mrremind  0.170.1
rev6.545                         mrremind  0.170.1
rev6.56-test_SSP5_industry       mrremind  0.170.1
rev6.545                         mrremind  0.170.1
rev6.57ARIADNEtrsp               mrremind  0.170.2
rev6.56-test_SSP5_industry_fix1  mrremind  0.170.2.9001
rev6.56-test_SSP5_industry_fix2  mrremind  0.170.2.9002
rev6.542falks-cache              mrremind  0.170.3
rev6.542APT-2023-10-22           mrremind  0.170.3

and all REMIND calibrations based on those input data revisions.

REMIND runs using these input data revisions, but a calibration based on prior input data (i.e. up to https://github.com/remindmodel/CESparameters/commit/ce96f1f97389c0b49757726259a40754a3c930b3) are not affected. (https://github.com/remindmodel/CESparameters/commit/216c0ede4f08158971a8aa8a80de94387e031809 is lacking provenance, so it is not possible to tell.)

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q merged commit ed05862 into pik-piam:master Oct 27, 2023
1 check passed
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q deleted the fix/otherInd_regression branch October 27, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants