-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trajectories for incineration rates for plastic waste #449
Merged
mellamoSimon
merged 10 commits into
pik-piam:master
from
mellamoSimon:add-incineration-trajectories
Nov 23, 2023
Merged
Add trajectories for incineration rates for plastic waste #449
mellamoSimon
merged 10 commits into
pik-piam:master
from
mellamoSimon:add-incineration-trajectories
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on plastics end of life
…on/mrremind into add-incineration-trajectories
…olate missing years, correct intervals after 2010, and remove redundant dimension
…d-incineration-trajectories
mellamoSimon
requested review from
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q and
fbenke-pik
November 21, 2023 17:01
fbenke-pik
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure lucode2::buildLibrary() succeeds and the version is incremented. This should also include fixing remaining linter warnings.
`Plastics|Waste|Total`
",
units = "fraction", only.new = TRUE
- ) %>%
- # remove unused dimensions
- select(c(-model,-scenario,-variable,-unit)) %>%
- interpolate_missing_periods(seq(2050,2060,5),method = "linear")
+ ) %>%
+ # remove unused dimensions
+ select(-"model", -"scenario", -"variable", -"unit") %>%
+ interpolate_missing_periods(seq(2050, 2060, 5), method = "linear")
# as magpie
x <- as.magpie(incinerationShares) |
thank you! |
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
approved these changes
Nov 23, 2023
fbenke-pik
approved these changes
Nov 23, 2023
mellamoSimon
added
the
Chemicals
Collection of PRs relevant for our new colleague modeling the chemical industry
label
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds required functions and a mapping to create an input file with incineration rates for plastic waste, using data from PBL's Steggman et.al.