Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance tests #423

Merged
merged 3 commits into from
Dec 20, 2024
Merged

enhance tests #423

merged 3 commits into from
Dec 20, 2024

Conversation

fbenke-pik
Copy link
Collaborator

@fbenke-pik fbenke-pik commented Dec 20, 2024 •
edited
Loading

Purpose of this PR

  • add a test for ScenarioMIP interpolation
  • enhance test for summation checks to avoid introducing dummy entries in project-specific summation files

Checklist:

  • I did not use Excel to open csv files or checked that no side-effects occur (changed values, many new quotation marks, …)
  • I added any renamed piam_variable to renamed_piam_variables.csv to guarantee backwards compatibility.

It is recommended to have a look at the tutorial before submission.

@fbenke-pik
Copy link
Collaborator Author

@laurinks @merfort FYI

merfort
merfort approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@merfort merfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adjusting this, Falk!

@fbenke-pik fbenke-pik merged commit e526353 into pik-piam:master Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merfort merfort merfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbenke-pik @merfort