Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test gdx files, relax checkSummation #613

Merged
merged 4 commits into from
Jul 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildlibrary
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ValidationKey: '228122760'
ValidationKey: '228165588'
AcceptedWarnings:
- 'Warning: package ''.*'' was built under R version'
- 'Warning: namespace ''.*'' is not available and has been replaced'
Expand Down
4 changes: 2 additions & 2 deletions CITATION.cff
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ cff-version: 1.2.0
message: If you use this software, please cite it using the metadata from this file.
type: software
title: 'remind2: The REMIND R package (2nd generation)'
version: 1.146.0
date-released: '2024-07-02'
version: 1.146.1
date-released: '2024-07-04'
abstract: Contains the REMIND-specific routines for data and model output manipulation.
authors:
- family-names: Rodrigues
Expand Down
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Type: Package
Package: remind2
Title: The REMIND R package (2nd generation)
Version: 1.146.0
Date: 2024-07-02
Version: 1.146.1
Date: 2024-07-04
Authors@R: c(
person("Renato", "Rodrigues", , "[email protected]", role = c("aut", "cre")),
person("Lavinia", "Baumstark", role = "aut"),
Expand Down
8 changes: 3 additions & 5 deletions R/convGDX2MIF.R
Original file line number Diff line number Diff line change
Expand Up @@ -151,18 +151,16 @@ convGDX2MIF <- function(gdx, gdx_ref = NULL, file = NULL, scenario = "default",
sumChecks <- checkSummations(
mifFile = output, dataDumpFile = NULL, outputDirectory = NULL,
summationsFile = "extractVariableGroups",
absDiff = 1.5e-8, relDiff = 1e-8, roundDiff = TRUE
) %>%
filter(abs(.data$diff) >= 1.5e-8),
absDiff = 0.01, relDiff = 0.02, roundDiff = TRUE
),
type = 'message') %>%
.reportSummationErrors(testthat = testthat)

capture.output(sumChecks <- checkSummations(
mifFile = output, dataDumpFile = NULL, outputDirectory = NULL,
summationsFile = system.file('extdata/additional_summation_checks.csv',
package = 'remind2'),
absDiff = 1.5e-8, relDiff = 1e-8, roundDiff = TRUE) %>%
filter(abs(.data$diff) >= 1.5e-8) %>%
absDiff = 0.01, relDiff = 0.02, roundDiff = TRUE) %>%
bind_rows(sumChecks),
type = 'message'
) %>%
Expand Down
4 changes: 2 additions & 2 deletions R/loadModeltest.R
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,14 @@ cs2InputPaths <- function(outputDirs) {
#' ssp1 <- new.env()
#' ssp2eu <- new.env()
#' loadModeltest(ssp1, "^SSP1-AMT-")
#' loadModeltest(ssp2eu, "^SSP2EU-.*-AMT$")
#' loadModeltest(ssp2eu, "^SSP2-.*-AMT$")
#' ssp1$data
#' ssp2eu$data
#' }
#' @export
loadModeltest <- function(
envir = globalenv(),
namePattern = "^SSP2EU-.*-AMT$",
namePattern = "^SSP2-.*-AMT$",
folder = tempdir()
) {

Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# The REMIND R package (2nd generation)

R package **remind2**, version **1.146.0**
R package **remind2**, version **1.146.1**

[![CRAN status](https://www.r-pkg.org/badges/version/remind2)](https://cran.r-project.org/package=remind2) [![R build status](https://github.com/pik-piam/remind2/workflows/check/badge.svg)](https://github.com/pik-piam/remind2/actions) [![codecov](https://codecov.io/gh/pik-piam/remind2/branch/master/graph/badge.svg)](https://app.codecov.io/gh/pik-piam/remind2) [![r-universe](https://pik-piam.r-universe.dev/badges/remind2)](https://pik-piam.r-universe.dev/builds)

Expand Down Expand Up @@ -49,7 +49,7 @@ In case of questions / problems please contact Renato Rodrigues <renato.rodrigue

To cite package **remind2** in publications use:

Rodrigues R, Baumstark L, Benke F, Dietrich J, Dirnaichner A, Duerrwaechter J, Führlich P, Giannousakis A, Hasse R, Hilaire J, Klein D, Koch J, Kowalczyk K, Levesque A, Malik A, Merfort A, Merfort L, Morena-Leiva S, Pehl M, Pietzcker R, Rauner S, Richters O, Rottoli M, Schötz C, Schreyer F, Siala K, Sörgel B, Spahr M, Strefler J, Verpoort P, Weigmann P, Rüter T (2024). _remind2: The REMIND R package (2nd generation)_. R package version 1.146.0, <https://github.com/pik-piam/remind2>.
Rodrigues R, Baumstark L, Benke F, Dietrich J, Dirnaichner A, Duerrwaechter J, Führlich P, Giannousakis A, Hasse R, Hilaire J, Klein D, Koch J, Kowalczyk K, Levesque A, Malik A, Merfort A, Merfort L, Morena-Leiva S, Pehl M, Pietzcker R, Rauner S, Richters O, Rottoli M, Schötz C, Schreyer F, Siala K, Sörgel B, Spahr M, Strefler J, Verpoort P, Weigmann P, Rüter T (2024). _remind2: The REMIND R package (2nd generation)_. R package version 1.146.1, <URL: https://github.com/pik-piam/remind2>.

A BibTeX entry for LaTeX users is

Expand All @@ -58,7 +58,7 @@ A BibTeX entry for LaTeX users is
title = {remind2: The REMIND R package (2nd generation)},
author = {Renato Rodrigues and Lavinia Baumstark and Falk Benke and Jan Philipp Dietrich and Alois Dirnaichner and Jakob Duerrwaechter and Pascal Führlich and Anastasis Giannousakis and Robin Hasse and Jérome Hilaire and David Klein and Johannes Koch and Katarzyna Kowalczyk and Antoine Levesque and Aman Malik and Anne Merfort and Leon Merfort and Simón Morena-Leiva and Michaja Pehl and Robert Pietzcker and Sebastian Rauner and Oliver Richters and Marianna Rottoli and Christof Schötz and Felix Schreyer and Kais Siala and Björn Sörgel and Mike Spahr and Jessica Strefler and Philipp Verpoort and Pascal Weigmann and Tonn Rüter},
year = {2024},
note = {R package version 1.146.0},
note = {R package version 1.146.1},
url = {https://github.com/pik-piam/remind2},
}
```
1 change: 1 addition & 0 deletions inst/compareScenarios/cs_06_energy_services.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ if ("Production|Industry|Steel|BF-BOF" %in% levels(data$variable)){ # if process
showAreaAndBarPlots(droute, items, tot, orderVars="user", scales = "fixed")
}
```

### Subsector per-Capita Production
```{r plot subsector per-capita production}
items <- c("Production|Industry|Cement|per-capita",
Expand Down
4 changes: 2 additions & 2 deletions man/loadModeltest.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions tests/testthat/test-convGDX2mif.R
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ library(gdx)
test_that("Test if REMIND reporting is produced as it should and check data integrity", {
skip_if_not(as.logical(gdxrrw::igdx(silent = TRUE)), "gdxrrw is not initialized properly")

orichters marked this conversation as resolved.
Show resolved Hide resolved
# GDXs for comparison. Once the remind2::reportEmi does not report negative gross emissions we will switch to SSP2EU-EU21-PkBudg and SSP2EU-NPi
gdxList <- c("fulldata-release.gdx" = "https://rse.pik-potsdam.de/data/example/remind2_test-convGDX2MIF_SSP2EU-EU21-NPi_2024-03-28_10.23.13.gdx",
"fulldata-AMT.gdx" = "https://rse.pik-potsdam.de/data/example/remind2_test-convGDX2MIF_SSP2EU-PkBudg650-AMT.gdx")
# GDXs for comparison.
gdxList <- c("fulldata-SSP2-EU21-PkBudg650-release.gdx" = "https://rse.pik-potsdam.de/data/example/remind2_test-convGDX2MIF_SSP2-EU21-PkBudg650_2024-06-18_22.43.19.gdx",
"fulldata-SSP2-NPi-AMT.gdx" = "https://rse.pik-potsdam.de/data/example/remind2_test-convGDX2MIF_SSP2-NPi-AMT.gdx")

gdxPaths <- NULL
for (i in seq_along(gdxList)) {
Expand Down