This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Don't raise RetryError but rather the underlying error #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way in the CLI the user is presented with a more meaningfull error.
acatav
approved these changes
Oct 26, 2023
In the tests we get the full stack trace, so we can always see the underling error. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #104
Solution
Using tenacity's
reraiseflag, which means that instead of raisingRetryError, the actual underlying error is raised.This way in the CLI the user is presented with a more meaningful error.
Type of Change