Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

fix metadata filtering #109

Merged
merged 2 commits into from
Oct 26, 2023
Merged

fix metadata filtering #109

merged 2 commits into from
Oct 26, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Oct 26, 2023

Problem

KB use metadata_filter instead of filter param in query to Pinecone, so metadata filtering not working

Solution

Use the correct param name

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Added a new test for metadata filtering

Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!

LGTM

@acatav acatav enabled auto-merge October 26, 2023 12:57
@acatav acatav merged commit 3f81ab4 into dev Oct 26, 2023
10 checks passed
@acatav acatav deleted the fix-query-with-metadata-filter branch October 26, 2023 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants