Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Allow re-initialize of tokenizer #110

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Allow re-initialize of tokenizer #110

merged 4 commits into from
Oct 26, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Oct 26, 2023

Problem

Global tokenizer not allow re-initialize. This make it harder to work with notebooks the often re-run cells, and also to change the tokenizer as you go

Solution

Allow re-initialization of tokenizer

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Changed according test

Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

See one test suggestion

@acatav acatav enabled auto-merge October 26, 2023 13:58
@acatav acatav merged commit 21db56a into dev Oct 26, 2023
10 checks passed
@acatav acatav deleted the allow-reinitilize-tokenizer branch October 26, 2023 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants