Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

pass kwargs to context to text method #111

Merged
merged 3 commits into from
Oct 26, 2023
Merged

pass kwargs to context to text method #111

merged 3 commits into from
Oct 26, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Oct 26, 2023

Problem

passing args to to_text method of context result is not supported. It can be a nice feature for printing in notebooks etc

Solution

Support kwargs for to_text

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Added a unit test

@acatav acatav enabled auto-merge October 26, 2023 14:10
igiloh-pinecone
igiloh-pinecone approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acatav acatav merged commit ee8c58d into dev Oct 26, 2023
10 checks passed
@acatav acatav deleted the kwargs-context-to-text branch October 26, 2023 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igiloh-pinecone igiloh-pinecone igiloh-pinecone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acatav @igiloh-pinecone