Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

move to chat message data models to Canopy from data models module #112

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Oct 26, 2023

Problem

Role messages data models like UserMessage are not in canopy.models.data_models module where their base class is

Solution

Move this models to canopy.models.data_models

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Only moving classes around, should be captured by existing tests

Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acatav acatav enabled auto-merge October 26, 2023 14:11
@acatav acatav merged commit 65aa103 into dev Oct 26, 2023
10 checks passed
@acatav acatav deleted the move-messages-classes-to-data-models branch October 26, 2023 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants