Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

[cli] added --index-name option to canopy start #114

Merged
merged 1 commit into from
Oct 29, 2023
Merged

[cli] added --index-name option to canopy start #114

merged 1 commit into from
Oct 29, 2023

Conversation

igiloh-pinecone
Copy link
Contributor

Problem

Resolves #105

Solution

Somewhat hacky solution - simply set the env var.

Type of Change

  • New feature (non-breaking change which adds functionality)

@acatav acatav self-requested a review October 29, 2023 08:34
acatav
acatav approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@acatav acatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auto-merge was automatically disabled October 29, 2023 15:17

Merge queue setting changed

@igiloh-pinecone igiloh-pinecone added this pull request to the merge queue Oct 29, 2023
Merged via the queue into dev with commit c83da5e Oct 29, 2023
19 checks passed
@igiloh-pinecone igiloh-pinecone deleted the start_index_name branch October 29, 2023 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acatav acatav acatav approved these changes

@miararoy miararoy Awaiting requested review from miararoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igiloh-pinecone @acatav