Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Ignore additional params in chat completion #137

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Ignore additional params in chat completion #137

merged 1 commit into from
Nov 5, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Nov 2, 2023

Problem

Chat completion API expected to be OpenAI compatible, so it should allow any OpenAI param in the request even if it's not used.

Solution

Ignore additional params in the data model of the request

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Added a e2e test for passing additional params

Merged via the queue into dev with commit b90769d Nov 5, 2023
10 checks passed
@acatav acatav deleted the allow-additional-param-chat-completion branch November 5, 2023 09:02
igiloh-pinecone
igiloh-pinecone approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acatav acatav added this pull request to the merge queue Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igiloh-pinecone igiloh-pinecone igiloh-pinecone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acatav @igiloh-pinecone