make plugin usable at site level in branch "stable-3_3_0" #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A comment on this PR after my issue: pkp/pkp-lib#8371 (comment) I tested the PR and it works. However the intention was to update the locales on site level as described here: You might need to change that translating guide example then if the plugin does not support changes in site level. |
|
can we merge this request? |
asmecher
added a commit
that referenced
this pull request
May 10, 2024
asmecher
added a commit
that referenced
this pull request
May 10, 2024
|
@edelm, I've merged the PR, and ported it forward to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #11 , I made the suggested changes and tested them. This pull requests prevents the crashing of OJS, when using the plugin at site level.