Introduce typehinting and general cleanup: Core classes 2

pkp · Jun 17, 2024 · 282c7dd · 282c7dd
1 parent dcbe60b
commit 282c7dd
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 18 deletions.
diff --git a/classes/issue/IssueGalleyDAO.php b/classes/issue/IssueGalleyDAO.php
@@ -214,21 +214,17 @@ public function getByBestId($galleyId, $issueId)
 
     /**
      * Get the list of fields for which data is localized.
-     *
-     * @return array
      */
-    public function getLocaleFieldNames()
+    public function getLocaleFieldNames(): array
     {
         return [];
     }
 
     /**
      * Get a list of additional fields that do not have
      * dedicated accessors.
-     *
-     * @return array
      */
-    public function getAdditionalFieldNames()
+    public function getAdditionalFieldNames(): array
     {
         $additionalFields = parent::getAdditionalFieldNames();
         // FIXME: Move this to a PID plug-in.

diff --git a/classes/subscription/SubscriptionTypeDAO.php b/classes/subscription/SubscriptionTypeDAO.php
@@ -185,10 +185,8 @@ public function _fromRow($row)
 
     /**
      * Get the list of field names for which localized data is used.
-     *
-     * @return array
      */
-    public function getLocaleFieldNames()
+    public function getLocaleFieldNames(): array
     {
         return ['name', 'description'];
     }

diff --git a/classes/subscription/form/SubscriptionPolicyForm.php b/classes/subscription/form/SubscriptionPolicyForm.php
@@ -148,10 +148,8 @@ public function readInputData()
 
     /**
      * Get the names of the fields for which localized settings are used
-     *
-     * @return array
      */
-    public function getLocaleFieldNames()
+    public function getLocaleFieldNames(): array
     {
         return ['subscriptionAdditionalInformation'];
     }

diff --git a/controllers/grid/settings/sections/form/SectionForm.php b/controllers/grid/settings/sections/form/SectionForm.php
@@ -138,10 +138,8 @@ public function readInputData()
 
     /**
      * Get the names of fields for which localized data is allowed.
-     *
-     * @return array
      */
-    public function getLocaleFieldNames()
+    public function getLocaleFieldNames(): array
     {
         return ['title', 'policy', 'abbrev', 'identifyType'];
     }

diff --git a/controllers/grid/subscriptions/SubscriptionTypeForm.php b/controllers/grid/subscriptions/SubscriptionTypeForm.php
@@ -89,10 +89,8 @@ public function __construct($journalId, $typeId = null)
 
     /**
      * Get a list of localized field names for this form
-     *
-     * @return array
      */
-    public function getLocaleFieldNames()
+    public function getLocaleFieldNames(): array
     {
         $subscriptionTypeDao = DAORegistry::getDAO('SubscriptionTypeDAO'); /** @var SubscriptionTypeDAO $subscriptionTypeDao */
         return $subscriptionTypeDao->getLocaleFieldNames();