Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#9456 Add private notes for reviewers #4110

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

nibou230
Copy link
Contributor

How to test?

This test can only be done if the OJS instance has multiple journals on it.

  1. Ensure the user on which notes will be used is at least associated to 2 journals.
  2. As an editor In journal A: add the reviewer to a submission, then clic on Editorial notes in the reviewer menu. Add both a public and private notes
  3. As an editor in journal B: add the same reviewer to a submission. In the add user window, display all information about the reviewer: only the public editorial note add by Editor of journal A is displayed.
  4. Clic on Editorial notes in the reviewer menu. Add a private note.
  5. As an editor In journal A, add the same reviewer to a new submission, in the add reviewer window, display reviewer details, you should see the private notes of Journal A, not the one from Journal B.

@jonasraoni jonasraoni linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link
Member

@asmecher asmecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not a big deal -- but the indentation in the XML files should use tabs for consistency.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowing user private editorial notes in OJS
2 participants