pkp/pkp-lib#10744 Increase opportunity for ORCID work/review deposits #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taslangraham
force-pushed
the
i10744-main
branch
from
87e4e39 to
6666143
Compare
taslangraham
changed the title
taslangraham
force-pushed
the
i10744-main
branch
2 times, most recently
from
687b483 to
cc911e8
Compare
ewhanson
reviewed
Jan 9, 2025
| @@ -74,6 +77,10 @@ public function submissionMetadataChanged($submission) | |||
| $this->_updateTextIndex($submissionId, SubmissionSearch::SUBMISSION_SEARCH_TYPE, (array) $publication->getData('type')); | |||
| $this->_updateTextIndex($submissionId, SubmissionSearch::SUBMISSION_SEARCH_COVERAGE, (array) $publication->getData('coverage')); | |||
| // FIXME Index sponsors too? | |||
|
|
|||
| if ($publication->getData('status') == PKPSubmission::STATUS_PUBLISHED) { | |||
There was a problem hiding this comment.
This looks good for now, but just as a note, I'd eventually like to move all things making use of this for downstream metadata consumers do so via event listeners, but not necessary for 3.5. We can revisit once 3.5 is out.
taslangraham
force-pushed
the
i10744-main
branch
2 times, most recently
from
9f29841 to
6a4ff76
Compare
taslangraham
force-pushed
the
i10744-main
branch
2 times, most recently
from
1cf2e7f to
0013bb4
Compare
taslangraham
force-pushed
the
i10744-main
branch
from
0013bb4 to
b098341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pkp/pkp-lib#10744