#1660 fixed issue with removable case

pkp · Dec 6, 2024 · cd81c1a · cd81c1a
1 parent 05100d8
commit cd81c1a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/classes/components/listPanels/ReviewerRecommendationsListPanel.php b/classes/components/listPanels/ReviewerRecommendationsListPanel.php
@@ -71,6 +71,8 @@ public function getConfig()
                 'confirmActivateMessage' => __('manager.reviewerRecommendations.confirmActivate'),
                 'deactivateTitle' => __('manager.reviewerRecommendations.deactivate.title'),
                 'confirmDeactivateMessage' => __('manager.reviewerRecommendations.confirmDeactivate'),
+                'recommendationNameTitle' => __('manager.reviewerRecommendations.list.name.title'),
+                'recommendationStatusTitle' => __('manager.reviewerRecommendations.list.status.title'),
                 'apiUrl' => $this->getReviewerRecommendationsApiUrl(),
                 'form' => $this->getLocalizedForm(),
                 'items' => $this->items,

diff --git a/classes/submission/reviewer/recommendation/ReviewerRecommendation.php b/classes/submission/reviewer/recommendation/ReviewerRecommendation.php
@@ -143,7 +143,7 @@ protected function value(): Attribute
     protected function removable(): Attribute
     {
         return Attribute::make(
-            get: fn () => Repo::reviewAssignment()
+            get: fn () => !Repo::reviewAssignment()
                 ->getCollector()
                 ->filterByRecommenddations([$this->value])
                 ->getQueryBuilder()

diff --git a/locale/en/manager.po b/locale/en/manager.po
@@ -1999,6 +1999,12 @@ msgstr "Are you sure you want to deactivate the recommendation {$title}"
 msgid "manager.reviewerRecommendations.deactivate.title"
 msgstr "Deactivate Reviewer Recommendation"
 
+msgid "manager.reviewerRecommendations.list.name.title"
+msgstr "Recommendations"
+
+msgid "manager.reviewerRecommendations.list.status.title"
+msgstr "Activate"
+
 msgid "manager.reviewForms"
 msgstr "Review Forms"