Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UI Language in Web and Announcement RSS2 Feeds #9910

Closed
bozana opened this issue Apr 24, 2024 · 2 comments
Closed

Use UI Language in Web and Announcement RSS2 Feeds #9910

bozana opened this issue Apr 24, 2024 · 2 comments
Assignees
@bozana @pkp-dev-distribution
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Milestone
3.5.0 LTS

Comments

@bozana
Copy link
Collaborator

bozana commented Apr 24, 2024 •
edited
Loading

In RSS2 feeds, in WebFeed and AnnouncementFeed plugin, we provide localized data, but the element language contains journal primary language.
According to the https://www.rssboard.org/rss-language-codes:

The language employed in an RSS feed can be indicated in the language element,...

the language element should then also contain the UI language in the format ISO 639-1.

PRs:
webFeed: pkp/webFeed#3
ojs announcementFeed: pkp/ojs#4368
@bozana bozana added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Apr 24, 2024
@bozana bozana modified the milestones: 3.4.0-x, 3.5.0 LTS Apr 24, 2024
@bozana bozana mentioned this issue Apr 24, 2024
Closed
@bozana bozana added the Try Me This issue might be good for a new contributor. Can you help us? label Jun 13, 2024
bozana added a commit to bozana/webFeed that referenced this issue Jul 16, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Web Feeds
664a777
@bozana bozana mentioned this issue Jul 16, 2024
Merged
bozana added a commit to bozana/ojs that referenced this issue Jul 16, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Announcement Feeds
b933268
@bozana bozana mentioned this issue Jul 16, 2024
Merged
@bozana
Copy link
Collaborator Author

bozana commented Jul 16, 2024

Hi @jonasraoni, could you please review the PRs above?
Thanks a lot!

bozana added a commit to bozana/webFeed that referenced this issue Jul 17, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Web Feeds
458ebd8
bozana added a commit to bozana/ojs that referenced this issue Jul 17, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Announcement Feeds
d74620c
bozana added a commit to bozana/webFeed that referenced this issue Jul 18, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Web Feeds
b4ca57f
@bozana bozana self-assigned this Aug 29, 2024
bozana added a commit to bozana/webFeed that referenced this issue Dec 12, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Web Feeds
0ab13fd
bozana added a commit to bozana/webFeed that referenced this issue Dec 12, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Web Feeds
32afe65
bozana added a commit to bozana/ojs that referenced this issue Dec 12, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Announcement Feeds
397d213
@bozana
Copy link
Collaborator Author

bozana commented Jan 3, 2025

Hi @jonasraoni, could you take a look at this one? Thanks a lot!

bozana added a commit to bozana/webFeed that referenced this issue Jan 13, 2025
@bozana
pkp/pkp-lib#9910 Use UI Language in Web Feeds
b495687
bozana added a commit to pkp/webFeed that referenced this issue Jan 13, 2025
@bozana
Merge pull request #3 from bozana/9910
28b8231 
pkp/pkp-lib#9910 Use UI Language in Web Feeds
bozana added a commit to bozana/ojs that referenced this issue Jan 13, 2025
@bozana
pkp/pkp-lib#9910 Use UI Language in Announcement Feeds
b50ced4
bozana added a commit to bozana/ojs that referenced this issue Jan 13, 2025
@bozana
pkp/pkp-lib#9910 web feed sugmodule update ##bozana/9910##
a4d1705
bozana added a commit to pkp/ojs that referenced this issue Jan 13, 2025
@bozana
Merge pull request #4368 from bozana/9910
ae58968 
pkp/pkp-lib#9910 Use UI Language in Announcement Feeds
@bozana bozana closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

@pkp-dev-distribution pkp-dev-distribution

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
2 participants
@bozana @pkp-dev-distribution