pkp/pkp-lib#9910 Use UI Language in Web Feeds #3
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasraoni
reviewed
Jul 16, 2024
jonasraoni
reviewed
Jul 16, 2024
jonasraoni
requested changes
Jul 16, 2024
There was a problem hiding this comment.
@bozana I just think it's better to keep the country information of the locale (if available).
|
Hi @jonasraoni, I considered the comments, could you please take another look? |
jonasraoni
reviewed
Jul 17, 2024
bozana
commented
Jul 18, 2024
|
@jonasraoni, what about this solution? |
jonasraoni
approved these changes
Jul 22, 2024
bozana
force-pushed
the
9910
branch
2 times, most recently
from
0ab13fd to
32afe65
Compare
|
Hi @jonasraoni, I was waiting with this PR till I have finished the integration of Weblate locales. Could you please take a look at it now? Thanks a lot! |
jonasraoni
requested changes
Jan 13, 2025
jonasraoni
reviewed
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s. pkp/pkp-lib#9910