pkp/pkp-lib#10744 Increase opportunity for ORCID work/review deposits #10756
+88
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taslangraham
force-pushed
the
i10744-main
branch
from
c1d7493 to
7874b0e
Compare
taslangraham
force-pushed
the
i10744-main
branch
from
7874b0e to
3e79926
Compare
ewhanson
requested changes
Jan 9, 2025
| @@ -777,6 +778,9 @@ public function reviewRead($args, $request) | |||
| ->withType(Notification::NOTIFICATION_TYPE_REVIEW_ASSIGNMENT) | |||
| ->delete(); | |||
|
|
|||
| // Deposit review to ORCID | |||
| (new SendReviewToOrcid($reviewAssignment->getId()))->execute(); | |||
There was a problem hiding this comment.
This is great, but it got me thinking: do you think we should still send it again directly after this when the reviewer is thanked as well? It seems redundant to do it twice in quick succession, but curious what you think. If we do want to remove, it, it will need to be removed here:
There was a problem hiding this comment.
Now that you've mentioned it, I do agree that it is a bit redundant and there isn't anything gained from doing it when the reviewer is thanked if it was already done when the review was confirmed. I think it's best to have it at just the confirmation step.
There was a problem hiding this comment.
I've removed the call from thank reviewer flow
taslangraham
force-pushed
the
i10744-main
branch
2 times, most recently
from
34a863e to
94423fa
Compare
taslangraham
force-pushed
the
i10744-main
branch
from
94423fa to
4a4b7f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10744