SBA completed. #12
Open
SBA completed. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter successful registration.
Git-Leon
reviewed
Sep 7, 2020
|
|
||
| //nullary constructor | ||
| public Student(){ | ||
| this(null,null,null, null); |
There was a problem hiding this comment.
My bad. Will do. thank you.
| .findFirst() | ||
| .get(); | ||
| }catch(NullPointerException| NoSuchElementException e){ | ||
| System.out.println("Email address does not exist. Please enter valid email."); |
| } | ||
|
|
||
| @Override | ||
| public Boolean validateStudent(String studentEmail, String password) { | ||
| return null; | ||
| Boolean studentExists = getAllStudents() |
There was a problem hiding this comment.
consider
password.equals(Objects.requireNonNull(getStudentByEmail(studentEmail)).getPassword());
There was a problem hiding this comment.
Thank you for the one liner, I could not have thought about it! Trying it now. Thank you.
( I thought of using anyMatch() as it does not throw exception and returns false if the stream is empty. )
| try{ | ||
| String registerCourse = "INSERT INTO StudentCourses VALUES (?, ?)"; | ||
| PreparedStatement insertStatement = dbc.getDatabaseConnection().prepareStatement(registerCourse); | ||
| insertStatement.setString(1, studentEmail); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.