Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FINAL SBA SUBMISSION #4

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

FINAL SBA SUBMISSION #4

wants to merge 7 commits into from

Conversation

deepti102915
Copy link

No description provided.

@deepti102915 deepti102915 changed the title Database Connection Established Requirement 1 completed Sep 5, 2020
@deepti102915 deepti102915 changed the title Requirement 1 completed Requirement 2, 3 & 4 completed Sep 5, 2020
@deepti102915 deepti102915 changed the title Requirement 2, 3 & 4 completed Test Cases added Sep 6, 2020
Git-Leon
Git-Leon suggested changes Sep 6, 2020
View reviewed changes
src/main/java/com/github/perscholas/utils/ConnectionBuilder.java
.append("/")
.append(databaseName != null ? databaseName : "")
.append("?useUnicode=true&useJDBCCompliantTimezoneShift=true&useLegacyDatetimeCode=false&serverTimezone=UTC")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

src/test/java/com/github/perscholas/service/studentservice/TestConstructor.java
public class TestConstructor {

@Test
public void courseConstructorTest() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change line 20 to Assert.assertTrue(course instanceOf CourseInterface) to ensure the Course implements CourseInterface

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@deepti102915 deepti102915 changed the title Test Cases added Output Format Updated Sep 6, 2020
@deepti102915 deepti102915 changed the title Output Format Updated SBA COMPLETED Sep 8, 2020
@deepti102915 deepti102915 changed the title SBA COMPLETED FINAL SBA SUBMISSION Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Git-Leon Git-Leon Git-Leon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepti102915 @Git-Leon