sba school management system - ghassan nasr #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…processing of the .sql scripts in the resources folder.
…ally with each run of the application. Just need to handle some cases such as registering for the same course twice, and displaying courses better (right now just printing the object references).
Git-Leon
suggested changes
Sep 7, 2020
| return connectionBuilder | ||
| .setDatabaseName(getDatabaseName()) | ||
| .setParams(getParams()) |
| } | ||
|
|
||
| @Override | ||
| public void use() { | ||
| } | ||
|
|
||
| // GN added this to get a connection on the database engine without a database name | ||
| public void executeStatementOnEngine(String sqlStatement) { |
| @@ -24,6 +24,7 @@ public static void initialize() { | |||
| executeSqlFile("courses.populate-table.sql"); | |||
| executeSqlFile("students.create-table.sql"); | |||
| executeSqlFile("students.populate-table.sql"); | |||
| executeSqlFile("studentcourse.create-table.sql"); //GN added for many-to-many relationship between Student and Course | |||
| } | ||
|
|
||
| @Override | ||
| public Boolean validateStudent(String studentEmail, String password) { | ||
| return null; | ||
| String query = "SELECT * FROM Student WHERE email = \'" + |
| @@ -77,6 +82,7 @@ public String toString() { | |||
| .append(hasPortBeenSet ? portNumber : "") | |||
| .append("/") | |||
| .append(databaseName != null ? databaseName : "") | |||
| .append(params != null ? params : "") | |||
…s, one containing valid students, and one containing invalid students.
I added two parameterized tests using CSV files to GetStudentByEmailTest. Will add a few more ... |
…ecuteStatement to proreturn an int, which is the return type of JDBC executeUpdate that needs to be propagated up to any method calling executeStatement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…processing of the .sql scripts in the resources folder.