Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imports for *-mono-<= exercise #1080

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

negatratoron
Copy link

Closes #1079

Copy link
Member

@wadler wadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

*-comm should not be imported, not least because it is one of the later exercises.

@negatratoron negatratoron force-pushed the add-imports-for-exercise branch from d968db5 to 416e487 Compare January 8, 2025 12:25
@negatratoron
Copy link
Author

negatratoron commented Jan 8, 2025

Isn't *-comm an earlier exercise, in Induction?

I had added it because I used it in the proof, and figured it was reasonable to have that in the imports since +-comm is used in the example proof of +-mono-<=.

I did remove it from the PR, but IMO it should be present, even though it serves as a hint if the reader looks closely at the imports.

@negatratoron
Copy link
Author

While I have you here, thanks for all your effort on this book by the way! It's really well-written, and I also appreciate all the talks you've given that I can watch on youtube.

@negatratoron
Copy link
Author

@wadler Just a reminder, I made the change and I'm perfectly happy with it, go ahead and merge if you're ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import _*_ in Relations
2 participants