-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue tinymce customization docs #1808
Conversation
@petschki I made a few more revisions to bring it all together. Direct link to preview at https://plone6--1808.org.readthedocs.build/classic-ui/tinymce-customization.html |
Ok, I think we have only two solutions here. The "Formats+styles" and the The "Formats" JSON + registration in "Header/Inline/Block/Alignment/Table styles" field will insert the new format in the respective "Formats" submenu like this: On the other hand the The "Formats+styles" solution can be configured two ways:
The
Note: Step 3 is possible via TTW, but the other two steps happen in product code! As far as I see only the generic setup should be documented for I see no point for mixing TTW into it in this subchapter discussing how to add new formats using There is the topic of cleaning up the default barceloneta formats, where we have again two options:
So the question is more like: What is the target group of this page? Editors? Plone developers? Both? Depending on the answer the documentation should be split into parts. The GS stuff should be in the plone developers section and the TTW in the editors section of the page. |
@szakitibi I see what you're saying, but... read on. Cleaning up Barceloneta is up for discussion within the Classic UI team for inclusion in Plone 7 or later. That's beyond this PR's purpose, which is focused on Plone 6 Documentation. "TinyMCE customization" is for all audiences. We try not to cast any roles in Plone 6 Documentation. For example, let's say I'm performing the role of developer. I'm in a rush and I don't want to take the time to create an add-on. I can just copy-paste stuff from one site to another, as I only maintain two Plone sites, and complete the task in a few minutes. People search for how to perform a task, not their role. It's a principle from the Diátaxis framework. It's our job as documentarians to inform people toward making a decision that is appropriate to them. For example, we recently updated documentation for how to Install Plone to do that. As such, we can offer the options and inform readers of the requirements to perform the task, regardless of their role. After all that, is any of the information in this pull request not accurate? What specifically is missing or needs correction? Please let me know. Thank you! |
@petschki one final review from you, please. I think this is ready to merge. |
I cannot review, but approved 👍🏼 |
Continued from #1807 and implemented the comments.
@szakitibi not shure how and where to write the info, that the formats can only be placed on top if you use the third approach ... I'm open for suggestions.
📚 Documentation preview 📚: https://plone6--1808.org.readthedocs.build/