Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Classic UI Theming part #1831

Open
wants to merge 7 commits into
base: 6.0
Choose a base branch
from

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Jan 6, 2025

@stevepiercy
Copy link
Contributor Author

@plone/classicui-team please review.

@stevepiercy
Copy link
Contributor Author

First person to review this PR gets a 🍪 !

@petschki
@yurj
@MrTango
@jensens
@1letter

It has one section where I need some help to clarify it, please!

docs/classic-ui/theming/settings-ttw.md Outdated Show resolved Hide resolved
docs/classic-ui/theming/settings-ttw.md Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor Author

We have to ignore the pull request preview build failure for a while. I just filed an issue with RTD at readthedocs/readthedocs.org#11912

Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the restructuring here. Thank you!

@petschki
Copy link
Member

Where's my 🍪 😉

@stevepiercy
Copy link
Contributor Author

Where's my 🍪 😉

I'll bring a batch for the next PloneConf or sprint. 😁

I need help with this TODO, as I don't have the experience or knowledge. If y'all can give me some notes, I can wordsmith something together.

https://plone6--1831.org.readthedocs.build/classic-ui/theming/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Status: Approved
Development

Successfully merging this pull request may close these issues.

Restructure Classic UI / Theming Chapter
2 participants