Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login: suggested issuers #33

Merged
merged 17 commits into from
Mar 3, 2024
Merged

Conversation

angelo-v
Copy link
Contributor

@angelo-v angelo-v commented Mar 1, 2024

WIP to implement part of #21 - using a modal dialog instead of prompt allows browser's built-in autocomplete to be used and provided platform for further features

  • Create modal in pos-login & display modal on click - now waiting on refactor: split out pos-dialog #23
  • Duplicate functionality of getIdpUrl, i.e. a single input textbox with a default value
  • Style pos-login-form
  • Tests have been written
    • all new code is covered by unit tests
      • Add test for pos-login-form
      • Edit tests for pos-login
        • pos-login.spec.tsx
        • pos-login.integration.spec.tsx
    • the happy path of a new feature is covered by an end-to-end test
    • manual explorative tests have been performed
  • all dependencies are updated to the latest patch version at minimum
    • Done upstream
  • the CI pipeline passes
  • documentation is up-to-date
  • Possibly rename onIdpUrlSelected event

Edited 29 Jul to reduce scope of this PR. See #21 for backlog checklist

@angelo-v
Copy link
Contributor Author

angelo-v commented Mar 1, 2024

supersedes #22

@angelo-v angelo-v force-pushed the josephguillaume-suggested-issuers branch from 6d9700b to 36e8f67 Compare March 1, 2024 21:10
@angelo-v angelo-v force-pushed the josephguillaume-suggested-issuers branch 2 times, most recently from 24c56d3 to 8b1b086 Compare March 3, 2024 13:22
@angelo-v angelo-v force-pushed the josephguillaume-suggested-issuers branch from 6b775d6 to f506112 Compare March 3, 2024 13:36
@angelo-v angelo-v marked this pull request as ready for review March 3, 2024 16:00
@angelo-v angelo-v merged commit fe7524c into main Mar 3, 2024
8 checks passed
@angelo-v angelo-v deleted the josephguillaume-suggested-issuers branch October 4, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants