test: minikube cluster e2e tests #355
Open
+318
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisskii
requested review from
cdrage,
feloy and
odockal
and removed request for
a team
amisskii
force-pushed
the
minikube-cluster-e2e-test
branch
3 times, most recently
from
5756668 to
5806a5a
Compare
odockal
requested changes
Jan 17, 2025
tests/playwright/src/model/pages/minikube-cluster-creation-page.ts
Outdated
Show resolved
Hide resolved
| if (containerRuntime) { | ||
| await playExpect(this.driverCombobox).toBeVisible(); | ||
| const providerTypeOptions = await this.driverCombobox.locator('option').allInnerTexts(); | ||
| if (providerTypeOptions.includes(containerRuntime)) { |
| test('Uninstall Minikube extension', async ({ navigationBar }) => { | ||
| await navigationBar.openExtensions(); | ||
| await playExpect(extensionsPage.header).toBeVisible(); | ||
| const minikubeExtension = await extensionsPage.getInstalledExtension(EXTENSION_NAME, EXTENSION_LABEL); | ||
| await minikubeExtension.removeExtension(); | ||
| }); | ||
| }); | ||
|
|
||
| async function createMinikubeCluster(page: Page, clusterName: string = 'minikube', usedefaultOptions: boolean = true, timeout: number = 300_000, { driver, containerRuntime, baseImage, mountDefinition }: MinikubeClusterOptions = {}): Promise<void> { |
There was a problem hiding this comment.
maybe extract it into some local util file?
|
@amisskii But otherwise it looks good, tests are even passing on gha runners. |
amisskii
force-pushed
the
minikube-cluster-e2e-test
branch
5 times, most recently
from
19a56bf to
94c7ddd
Compare
odockal
reviewed
Jan 21, 2025
odockal
approved these changes
Jan 21, 2025
amisskii
force-pushed
the
minikube-cluster-e2e-test
branch
4 times, most recently
from
b58fd7e to
5c4e904
Compare
benoitf
reviewed
Jan 23, 2025
Signed-off-by: Anton Misskii <[email protected]>
amisskii
force-pushed
the
minikube-cluster-e2e-test
branch
from
c433a53 to
041f2f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #298