Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin Boto3 version to avoid breaking change #247

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

jstlaurent
Copy link
Contributor

@jstlaurent jstlaurent commented Jan 16, 2025

Changelogs

  • Pin Boto3 to < 1.36.0, to avoid a breaking change in the checksum request headers

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

Fixes #246.

Boto3 has changed its default behavior in 1.36.0. The header that is now added automatically is not supported by all S3-compatible services, such as Cloudflare R2, which is the backing store for the Polaris Hub storage. The suggested configuration to disable the new behavior does not appear to fix this issue in our case. I've elected to pin the Boto3 version for now.

@jstlaurent jstlaurent requested a review from cwognum as a code owner January 16, 2025 14:47
@jstlaurent jstlaurent added the fix Annotates any PR that fixes bugs label Jan 16, 2025
@jstlaurent jstlaurent self-assigned this Jan 16, 2025
Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jstlaurent!

Could you also make the change in the env.yml file?

pyproject.toml Show resolved Hide resolved
@jstlaurent jstlaurent requested a review from cwognum January 16, 2025 15:25
@jstlaurent jstlaurent merged commit 024c830 into main Jan 16, 2025
19 checks passed
@jstlaurent jstlaurent deleted the fix/boto3-checksum-error branch January 16, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Annotates any PR that fixes bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading error
2 participants