Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:修复nacos协议兼容中的问题 #1322

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

chuntaojun
Copy link
Member

Please provide issue(s) of this PR:
Fixes #

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Jan 11, 2024

2024-01-11 11:55:31: =========TEST START==========
2024-01-11 18:11:22: =========TEST START==========
2024-01-11 18:44:47: [STANDALONE VERSION]PR autotest FAILED! We executed 40 test cases and 37 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/prmain/sta/qta-report.html and https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/prmain/sta/ratelimit/qta-report.html
2024-01-11 18:44:51: [CLUSTER VERSION] PR autotest FAILED! We executed 39 test cases and 36 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/prmain/clu/qta-report.html
2024-01-11 18:44:55: [KUBENETES VERSION]PR autotest FAILED! We executed 39 test cases and 36 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/prmain/k8s/qta-report.html

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d23e0d4) 58.14% compared to head (1e7d58c) 58.19%.

Files Patch % Lines
config/config_file_release.go 86.95% 3 Missing ⚠️
config/server.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
+ Coverage   58.14%   58.19%   +0.04%     
==========================================
  Files         185      186       +1     
  Lines       37258    37285      +27     
==========================================
+ Hits        21664    21697      +33     
+ Misses      13009    13002       -7     
- Partials     2585     2586       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chuntaojun chuntaojun merged commit 7b40a69 into polarismesh:main Jan 11, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants