Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Usability Of CycleRange And RepeatRange For Already Materialized Sequences #773

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Improve Usability Of CycleRange And RepeatRange For Already Materialized Sequences #773

merged 3 commits into from
Jan 14, 2025

Conversation

bash
Copy link
Member

@bash bash commented Nov 30, 2023 •
edited
Loading

Resolves #740

@bash bash requested a review from FreeApophis November 30, 2023 13:35
@bash
Copy link
Member Author

bash commented Nov 30, 2023 •
edited
Loading

Open Questions

  • Do we want this at all?
  • This is a source breaking change as the return type for IReadOnlyCollection is different. Are we OK with this or should I rename the new overloads?

@bash bash marked this pull request as draft November 30, 2023 13:42
@FreeApophis
Copy link
Member

I think we should include this, I think the distinction is useful and avoiding the IBuffer is certainly a good thing for the usage.

@bash bash force-pushed the usability-of-repeat-range branch from 2582e0c to 59caf20 Compare January 14, 2025 09:33
@bash bash marked this pull request as ready for review January 14, 2025 09:33
@bash bash enabled auto-merge January 14, 2025 09:34
@bash
Copy link
Member Author

bash commented Jan 14, 2025 •
edited
Loading

As for naming: I went with your first suggestion: {Cycle,Repeat}Materialized. I really like that its succinct and descriptive. It also gives a hint to the .Materialize() method.

Quoting from #740 (comment):

  • Repeat/CycleMaterialized
  • Repeat/CycleEager(Range, Collection)
  • Repeat/CycleInMemory
  • Repeat/Cycle

@bash bash disabled auto-merge January 14, 2025 09:45
@bash bash enabled auto-merge January 14, 2025 09:49
@bash bash merged commit b0e5591 into main Jan 14, 2025
8 checks passed
@bash bash deleted the usability-of-repeat-range branch January 14, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreeApophis FreeApophis FreeApophis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usability of CycleRange and RepeatRange
2 participants
@bash @FreeApophis