Improve JWT.verify_strict/3
typespec with error tuple
#169
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for the great lib! 🎉
I think there might be an issue with the typespec for the mentioned function.
Currently
JOSE.JWT.verify_strict/3
returns, on some input,{:error, any()}
.However, this is not shown in the typespec - this causes the dialyzer to fail.
I'm attaching a demo script to test it out:
This could fix #167, and partialy #164 too.