Cleanup on file reads and writes. #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvella
commented
Feb 8, 2024
| @@ -32,8 +32,7 @@ fn bind_cli_args<F: FieldElement>( | |||
| let witness_values = witness_values | |||
| .map(|csv_path| { | |||
| let csv_file = fs::File::open(csv_path).unwrap(); | |||
| let mut csv_writer = BufReader::new(&csv_file); | |||
| read_polys_csv_file::<F>(&mut csv_writer) | |||
| read_polys_csv_file::<F>(csv_file) | |||
There was a problem hiding this comment.
csv::Reader has its own buffer, so BufReader is redundant here
lvella
commented
Feb 8, 2024
|
|
||
| write_polys_csv_file(&mut csv_writer, self.arguments.csv_render_mode, &columns); | ||
| let csv_file = fs::File::create(path).map_err(|e| vec![format!("{}", e)])?; | ||
| write_polys_csv_file(csv_file, self.arguments.csv_render_mode, &columns); |
There was a problem hiding this comment.
csv::Writer has its own buffer, so BufWriter is redundant here
chriseth
previously approved these changes
Feb 9, 2024
lvella
force-pushed
the
buffered_file_io
branch
from
6cf213c to
8c3c561
Compare
chriseth
previously approved these changes
Feb 9, 2024
lvella
force-pushed
the
buffered_file_io
branch
from
8c3c561 to
40950a9
Compare
leonardoalt
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vec<u8>reads withfs::read(),&[u8]writes withfs::write().