Process identities in order (if possible) #2323
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for the automatic pre-compile experiments @leonardoalt is running.
Changes the order in which runtime witgen for block machines processes identities.
The previous algorithm processed a given row like this:
With this PR, we do this:
What this gets us is that an identity is only executed if no previous identity identity has made progress. The order of identities is the order in which it appears in the PIL (I think!). This allows us to control the order in which stateful machine calls, like memory accesses, are executed.
I guess this can make the solving of the first block significantly (afterwards, the sequence cache should remove any identities that did not lead to progress). As an upper bound, witgen for
test_data/std/keccakf16_memory_test.asm
takes 347s now (instead of 309 onmain
) :)