Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powdr- prefix to crate names #921

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add powdr- prefix to crate names #921

merged 1 commit into from
Jan 23, 2024

Conversation

leonardoalt
Copy link
Member

I want to start preparing the crates for release and publishing on crates.io . The first convention is to name all crates powdr-*.

For now I only renamed the crates in Cargo.toml files, so the code doesn't compile. If we decide that this is fine and decide on some conventions, I'll go ahead and change the code as well.

asm_to_pil/Cargo.toml Outdated Show resolved Hide resolved
@leonardoalt leonardoalt force-pushed the rename-crates branch 3 times, most recently from b314551 to 61d7afc Compare January 22, 2024 17:23
@pacheco
Copy link
Collaborator

pacheco commented Jan 22, 2024

I don't have a preference either way, but it's also possible to rename the package used for the crate in the .toml file, to avoid using powdr_* in the code:
ast = { package = "powdr_ast", path = "../ast" }

@leonardoalt
Copy link
Member Author

I think I'd prefer to use the powdr- prefix everywhere to make it obvious what's from powdr

@leonardoalt leonardoalt force-pushed the rename-crates branch 4 times, most recently from a7ee2f7 to 3adf9a1 Compare January 23, 2024 13:06
chriseth
chriseth previously approved these changes Jan 23, 2024
chriseth
chriseth previously approved these changes Jan 23, 2024
@leonardoalt leonardoalt changed the base branch from main to fix-starky-jan January 23, 2024 18:24
@leonardoalt leonardoalt disabled auto-merge January 23, 2024 18:25
Base automatically changed from fix-starky-jan to main January 23, 2024 18:38
@leonardoalt leonardoalt added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit afbae63 Jan 23, 2024
2 checks passed
@leonardoalt leonardoalt deleted the rename-crates branch January 23, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants