remove runtime crate #928
remove runtime crate #928
Conversation
riscv/src/lib.rs
Outdated
| @@ -152,7 +152,7 @@ version = "0.1.0" | |||
| edition = "2021" | |||
|
|
|||
| [dependencies] | |||
| runtime = {{ path = "./runtime" }} | |||
| powdr_riscv_rt = {{ git = "https://github.com/powdr-labs/powdr", branch = "main" }} | |||
There was a problem hiding this comment.
Doesn't this also need the runtime subdirectory?
| @@ -4,6 +4,6 @@ version = "0.1.0" | |||
| edition = "2021" | |||
|
|
|||
| [dependencies] | |||
| runtime = { path = "../../../runtime" } | |||
| powdr-riscv-rt = { path = "../../../../powdr_riscv_rt" } | |||
There was a problem hiding this comment.
I would opt for actually spelling runtime out. rt can mean so many things.
There was a problem hiding this comment.
I think this is rather common. We use another crate called riscv_rt for qemu, so i thought powdr-riscv-rt fits well
There was a problem hiding this comment.
I mean, common also if you include the context you get from the "riscv" prefix to "rt"
There was a problem hiding this comment.
Even if it's common, I really don't think it's a good idea. We also don't abbreviate executor or other stuff.
There was a problem hiding this comment.
I mean isn't even runtime already an abbreviation for runtime environment?
There was a problem hiding this comment.
Ok. I still have a somewhat strong opinion about this. powdr-riscv-runtime is just really long and kinda clumsy. If someone else says they prefer it spelled out I'll give in.
There was a problem hiding this comment.
What does it matter if it's long and clumsy? Do you need to type it that often?
leonardoalt
force-pushed
the
remove-runtime
branch
from
2ddbcf8 to
ac9c1c3
Compare
leonardoalt
force-pushed
the
remove-runtime
branch
from
ac9c1c3 to
5cfc240
Compare
leonardoalt
force-pushed
the
remove-runtime
branch
from
5cfc240 to
387f1d4
Compare
leonardoalt
force-pushed
the
remove-runtime
branch
from
387f1d4 to
366d79f
Compare
For the tests that use crates it's possible to use the same powdr-riscv-rt crate from the checkout. For file tests we need to use git. I kept them separate for now but I can make everything git if that's preferred.