Split tests. #944
Split tests. #944
Conversation
.github/workflows/pr-tests.yml
Outdated
| - name: Create artifact archive | ||
| run: tar czf target.tar.gz target | ||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v2 |
There was a problem hiding this comment.
upload-artifact seems to have a compression-level option, so the archive step above could be omitted.
I think compression-level: 9 is the highest compression level.
Actually, it seems that by default it already uses level 6.
| with: | ||
| submodules: recursive | ||
| - name: Download build artifacts | ||
| uses: actions/download-artifact@v2 |
There was a problem hiding this comment.
These artifacts last only for the workflow duration?
There was a problem hiding this comment.
Yes - is there a better way in this case?
There was a problem hiding this comment.
No, its good like this, I was just wondering if we would hit space issues if not.
| @@ -65,9 +64,71 @@ jobs: | |||
| ~/.cargo/git | |||
| target | |||
| key: ${{ runner.os }}-cargo-pr-tests-${{ hashFiles('**/Cargo.toml') }} | |||
|
|
|||
| test_quick: | |||
| needs: build | |||
There was a problem hiding this comment.
Should test_quick and test_slow also run after the merge to main?
If not, we could add if: github.ref != 'refs/heads/main' here and on the test_slow section.
chriseth
force-pushed
the
split_tests
branch
3 times, most recently
from
3e8dcc4 to
4543c96
Compare
| with: | ||
| submodules: recursive | ||
| - name: Download build artifacts | ||
| uses: actions/download-artifact@v2 |
There was a problem hiding this comment.
No, its good like this, I was just wondering if we would hit space issues if not.
No description provided.