Skip to content

Commit

Permalink
Merge pull request #3 from agammathur/master
Browse files Browse the repository at this point in the history
Fixed broken links.
  • Loading branch information
agammathur authored Aug 31, 2020
2 parents 45122f0 + c024342 commit 7f37f5e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ The project allows the user to provide configuration at two levels:
To provide the configuration at build time use the **.env.development** and **env.production** files for development and production modes respectively. Some of the available options are:

##### Base Player
This project allows user to select the base player of his choice from the available player list. If your favourite player is not available in the supported player list and you are interested in contributing to the project to provide its support, then please refer the document [How to add a new player support](https://github.com/prebid/prebid-outstream/src/players).
This project allows user to select the base player of his choice from the available player list. If your favourite player is not available in the supported player list and you are interested in contributing to the project to provide its support, then please refer the document [How to add a new player support](https://github.com/prebid/prebid-outstream/blob/master/src/players/README.md).

The user needs to provide his selected player in **SELECTED_PLAYER** environment variable from the given supported player list.

Expand Down Expand Up @@ -157,4 +157,4 @@ By default, console logs will be disabled. To enable console logs for the projec
| 3 | Will log info, error and warn level logs. |
| 4 | Will log info, error, warn and debug level logs. |
| >5 | Will log info, error, warn, debug and log level logs. |
| Any other invalid value. | No logging |
| Any other invalid value. | No logging |
6 changes: 3 additions & 3 deletions src/players/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ At a high level, a player adapter is responsible for:
2. Play the outstream video Ad.
3. Implementing functions mentioned in GenericPlayer class.

This page has instructions for writing your own player adapter. The instructions here try to walk you through some of the code you’ll need to write for your adapter. When in doubt, use [the working adapters in the GitHub repo](https://github.com/prebid/prebid-outstream/src/players/fluid-player/FluidPlayer.js) for reference.
This page has instructions for writing your own player adapter. The instructions here try to walk you through some of the code you’ll need to write for your adapter. When in doubt, use [the working adapters in the GitHub repo](https://github.com/prebid/prebid-outstream/blob/master/src/players/fluid-player/FluidPlayer.js) for reference.

## Contributing
Contributions are always welcome. To contribute, [fork](https://help.github.com/articles/fork-a-repo/) prebid-outstream, commit your changes, and [open a pull request](https://help.github.com/articles/using-pull-requests/) against the master branch.
Expand All @@ -24,7 +24,7 @@ Before a Pull Request will be considered for merge:
6. Do a conditional import of the new player class depending on the value of *SELECTED_PLAYER* environment variable in the import section of *PlayerFactory.js* file.
7. Mention its entry in *PlayerFactory* class constructor function's switch statement and return its instance.
8. To use this new player-plugin combination as a base player for the project, assign this new unique name generated in step #5 to *SELECTED_PLAYER* environment variable.
9. Insert this new player entry in [README.md](https://github.com/prebid/prebid-outstream/README.md)
9. Insert this new player entry in [README.md](https://github.com/prebid/prebid-outstream/blob/master/README.md)


*Note 1:* Before raising the PR, please make sure the license of the player/plugin is compatible with the project.
*Note 1:* Before raising the PR, please make sure the license of the player/plugin is compatible with the project.

0 comments on commit 7f37f5e

Please sign in to comment.