-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter precice 3.1 with 3D support and "point load" #26
base: develop
Are you sure you want to change the base?
Changes from 15 commits
dbe3513
d91859b
f2fed88
21e9034
da285ff
11a3e7b
e91af7c
58a0db9
80380a5
452f027
844c9b4
fa29673
5695abf
9a15064
cbbc826
fc02757
8da8e15
45affcc
d90736d
55b5496
867917a
e94d5b7
4aebb55
de46fbf
74eedce
ac4a620
8242c91
6d1c52f
3be54df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
fenicsxprecice/_version.py export-subst | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as the license file. |
||
fenicsxprecice/_version.py export-subst |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should keep the build and test CI, hence we need this file, and the Action to pass. |
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to keep this CI. |
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as other CI related files. Let us keep this file to keep the check. |
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as other CI related files. Let us keep this file to keep the check. |
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as other CI related files. Let us keep this file to keep the check. |
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets keep this file. It is okay if the tutorial CI fails for now. Eventually when we move the case to the precice/tutorials repository, the CI will pass again. |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,5 @@ dist | |
.idea | ||
*.pyc | ||
.eggs/ | ||
.vscode | ||
.venv |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
{ | ||
"aliveStatusCodes": [429, 200, 0], | ||
"ignorePatterns": [ | ||
{ | ||
"pattern": "^https://openfoamwiki.net/" | ||
}, | ||
{ | ||
"pattern": "^https://doi.org/" | ||
} | ||
] | ||
} | ||
"aliveStatusCodes": [429, 200, 0], | ||
"ignorePatterns": [ | ||
{ | ||
"pattern": "^https://openfoamwiki.net/" | ||
}, | ||
{ | ||
"pattern": "^https://doi.org/" | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{ | ||
"MD013": false, | ||
"MD033": false | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,4 @@ | |
|
||
## current development | ||
|
||
* Forked initial version of this adapter from [`precice/[email protected]`](https://github.com/precice/fenics-adapter/releases/tag/v1.2.0). | ||
* Forked initial version of this adapter from [`precice/[email protected]`](https://github.com/precice/fenics-adapter/releases/tag/v1.2.0). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what the change is here. Please add a separate CHANGELOG entry describing the changes introduced in this pull request. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
include versioneer.py | ||
include fenicsxprecice/_version.py | ||
include fenicsxprecice/_version.py |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -20,7 +20,8 @@ Notes: | |||||
|
||||||
* This adapter is a fork from the original [FEniCS-preCICE adapter](https://github.com/precice/fenics-adapter). Based on [v1.2.0](https://github.com/precice/fenics-adapter/releases/tag/v1.2.0). | ||||||
* This adapter is currently under development and experimental. | ||||||
* Target version: dolfinx v0.5.2. Other version that have been tested and might also work: v0.4.1 | ||||||
* Target version: dolfinx v0.8.0. | ||||||
* Target version: preCICE v3. | ||||||
|
||||||
## Installing the package | ||||||
|
||||||
|
@@ -40,11 +41,11 @@ This should work out of the box, if all dependencies are installed correctly and | |||||
|
||||||
Make sure to install the following dependencies: | ||||||
|
||||||
* [preCICE](https://github.com/precice/precice/wiki) | ||||||
* [preCICE v3](https://github.com/precice/precice/wiki) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* python3 (this adapter **only supports python3**) | ||||||
* [the python language bindings for preCICE](https://github.com/precice/python-bindings) | ||||||
* :construction: [FEniCSx](https://fenicsproject.org/) (with python interface, installed by default) (under construction refer to notes on FEniCSx below) :construction: | ||||||
* and scipy (`pip3 install scipy`) | ||||||
|
||||||
Comment on lines
-47
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We no longer need scipy? |
||||||
|
||||||
#### Build and install the adapter | ||||||
|
||||||
|
@@ -91,3 +92,5 @@ If you are using FEniCSx, please also consider the information on [the official | |||||
2021: For development of FEniCSx support, `precice/[email protected]` was forked as `precice/fenicsx-adapter`. The required modifications were carried out by [Benjamin Rodenberg](https://www.cs.cit.tum.de/sccs/personen/benjamin-rodenberg/) and [Ishaan Desai](https://www.ipvs.uni-stuttgart.de/institute/team/Desai/). | ||||||
|
||||||
2023: [Philip Hildebrand](https://github.com/PhilipHildebrand) updated the adapter to a first minimal working version (https://github.com/precice/fenicsx-adapter/pull/15) and contributed a first tutorial (https://github.com/precice/tutorials/pull/317) in the scope of his Bachelor's thesis ["Extending the FEniCSx Adapter for the Coupling Library preCICE"](https://mediatum.ub.tum.de/node?id=1706280) under supervision of [Benjamin Rodenberg](https://www.cs.cit.tum.de/sccs/personen/benjamin-rodenberg/) and [Ishaan Desai](https://www.ipvs.uni-stuttgart.de/institute/team/Desai/). | ||||||
|
||||||
2024: [Eduardo Firvida](https://github.com/efirvida) updated the adapter to a minimal working version (https://github.com/precice/fenicsx-adapter/pull/26) with FSI and 3D support for preCICEv3. In the scope of his PhD Thesis. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to keep the documentation. |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
warnings.warn("No FEniCSx installation found on system. Please check whether it is found correctly. " | ||
"The FEniCSx adapter might not work as expected.\n\n") | ||
|
||
from .fenicsxprecice import Adapter | ||
from . import _version | ||
from .fenicsxprecice import Adapter | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this reordering necessary? |
||
__version__ = _version.get_versions()['version'] |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file is generated by versioneer. Please revert the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not change the license file. Can you please keep the original file?