fix: pypi installs happening every time #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-arts
approved these changes
Nov 28, 2024
jjjermiah
pushed a commit
to jjjermiah/pixi
that referenced
this pull request
Nov 30, 2024
## Description So @ruben-arts found out that we were installing the prefix too often, this came in with the uv upgrade that we re-introduced in a previous PR. So I think some bugginess was introduced to fix some lifetime issues, basically from what I was reading it was just installing even though the distributions were already installed. I've did a long-standing refactor that I wanted to do, that you actually get a reason why a reinstall is happening, which is often tricky to debug. I've also fixed the bug, cleaned up a lot of the debug statements so they make actual sense and report a lot more in general. Also, because of the new structure we can more directly tell why a reinstall happened because of keeping track of this as a a cause. ## Tested I've tested the following manual steps on rerun.io pixi toml: - [x] Install and re-install - [x] Clean and install - [x] Change an installer name in the prefix (to see if the log is triggered) - [x] Manually change a version in the prefix (to see if the debug log is triggered) I would like to add a automated test to stop a similar regression from happening: - [ ] Automated test
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So @ruben-arts found out that we were installing the prefix too often, this came in with the uv upgrade that we re-introduced in a previous PR.
So I think some bugginess was introduced to fix some lifetime issues, basically from what I was reading it was just installing even though the distributions were already installed.
I've did a long-standing refactor that I wanted to do, that you actually get a reason why a reinstall is happening, which is often tricky to debug.
I've also fixed the bug, cleaned up a lot of the debug statements so they make actual sense and report a lot more in general. Also, because of the new structure we can more directly tell why a reinstall happened because of keeping track of this as a a cause.
Tested
I've tested the following manual steps on rerun.io pixi toml:
I would like to add a automated test to stop a similar regression from happening: