chore: use current platform by default #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-arts
reviewed
Jan 3, 2025
baszalmstra
force-pushed
the
chore/use_prefix_channel_and_current_platform
branch
from
883d801 to
8be55db
Compare
ruben-arts
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we use
ALL_PLATFORMSfor theplatforms = [..]section in a few generated projects. I think this is unnecessary and we should useCURRENT_PLATFORMby default. The tests are run on a number of platforms anyway. There was also a tests that wasnt using the prefix.dev conda-forge channel yet which had some failures.