Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark tests as slow #2873

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Hofer-Julian
Copy link
Contributor

@Hofer-Julian Hofer-Julian commented Jan 10, 2025

  • >30s I marked as extra slow
  • >4s,<30s I marked as slow

> 30sec I marked as extra slow
> 4sec I marked as slow
@Hofer-Julian Hofer-Julian requested a review from nichmor January 10, 2025 08:52
@Hofer-Julian Hofer-Julian changed the title tests: mark tests as slow test: mark tests as slow Jan 10, 2025
@nichmor
Copy link
Contributor

nichmor commented Jan 10, 2025

it is possible to automate this somehow? ( in theory )

@Hofer-Julian
Copy link
Contributor Author

it is possible to automate this somehow? ( in theory )

Not a bad idea, but I wouldn't be aware of one.

Luckily, we set up pytest to tell us the duration of the 10 slowest tests, so slow tests are easy to detect.

@Hofer-Julian Hofer-Julian merged commit 47637ca into prefix-dev:main Jan 10, 2025
30 of 31 checks passed
@Hofer-Julian Hofer-Julian deleted the tests/mark-tests-slow branch January 10, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants