layout tweaks

premnirmal · Oct 29, 2022 · 508f829 · 508f829
1 parent 8d0eb1e
commit 508f829
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 21 deletions.
diff --git a/app/src/main/kotlin/com/github/premnirmal/ticker/news/NewsFeedFragment.kt b/app/src/main/kotlin/com/github/premnirmal/ticker/news/NewsFeedFragment.kt
@@ -87,7 +87,7 @@ class NewsFeedFragment : BaseFragment<FragmentNewsFeedBinding>(), ChildFragment,
     viewModel.fetchNews(forceRefresh = true)
   }
 
-  // NewsFeedAdapter.NewsClickListener
+  // TrendingAdapter.TrendingListener
 
   override fun onClickNewsArticle(article: NewsArticle) {
     CustomTabs.openTab(requireContext(), article.url)

diff --git a/app/src/main/res/layout-sw600dp-land/activity_quote_detail.xml b/app/src/main/res/layout-sw600dp-land/activity_quote_detail.xml
@@ -516,6 +516,30 @@
 
         </LinearLayout>
 
+        <TextView
+            android:id="@+id/description"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toBottomOf="@id/notes_container"
+            android:textAppearance="@style/TextAppearance.StocksWidget.BodyLightMedium"
+            style="@style/Widget.StocksWidget.TextView.BodyLightMedium"
+            android:layout_marginTop="8dp"
+            android:layout_marginStart="16dp"
+            android:layout_marginEnd="16dp"
+            />
+
+        <TextView
+            android:id="@+id/website"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toBottomOf="@id/description"
+            android:textAppearance="@style/TextAppearance.StocksWidget.ItalicLabelLarge"
+            style="@style/Widget.StocksWidget.TextView.ItalicLabelLarge"
+            android:layout_margin="16dp"
+            />
+
       </androidx.constraintlayout.widget.ConstraintLayout>
     </androidx.core.widget.NestedScrollView>
 
@@ -581,26 +605,6 @@
             app:layout_behavior="@string/appbar_scrolling_view_behavior"
             />
       </ViewFlipper>
-
-      <TextView
-          android:id="@+id/description"
-          android:layout_width="match_parent"
-          android:layout_height="wrap_content"
-          android:textAppearance="@style/TextAppearance.StocksWidget.BodyLightMedium"
-          style="@style/Widget.StocksWidget.TextView.BodyLightMedium"
-          android:layout_marginTop="8dp"
-          android:layout_marginStart="16dp"
-          android:layout_marginEnd="16dp"
-          />
-
-      <TextView
-          android:id="@+id/website"
-          android:layout_width="match_parent"
-          android:layout_height="wrap_content"
-          android:textAppearance="@style/TextAppearance.StocksWidget.ItalicLabelLarge"
-          style="@style/Widget.StocksWidget.TextView.ItalicLabelLarge"
-          android:layout_margin="16dp"
-          />
     </LinearLayout>
 
   </LinearLayout>

diff --git a/app/src/main/res/layout/item_news.xml b/app/src/main/res/layout/item_news.xml
@@ -59,6 +59,7 @@
     <ImageView
         android:layout_width="0dp"
         app:layout_constraintWidth_percent="0.2"
+        android:maxWidth="100dp"
         android:layout_height="0dp"
         app:layout_constraintDimensionRatio="1"
         android:scaleType="centerCrop"