chore: introduce style package #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
reviewed
Apr 11, 2020
| @@ -0,0 +1,11 @@ | |||
| # `style` | |||
|
|
|||
| > TODO: description | |||
There was a problem hiding this comment.
Suggested change
| > TODO: description | |
| > Provides a style object containing a variety of style parameters for theming Superset components with Emotion. See [SIP-37](https://github.com/apache/incubator-superset/issues/9123) for additional context. This will eventually allow for custom themes to override default Superset styles. These parameters (and the styled-components/emotion design pattern) will, over time, be used to whittle away at widely-scoped LESS styles, making it easier to build and (re)style Superset components. |
rusackas
reviewed
Apr 11, 2020
| const style = require('..'); | ||
|
|
||
| describe('style', () => { | ||
| it('needs tests'); |
There was a problem hiding this comment.
Hmmm... not sure what tests to add here... checking for the existence of styles (in case of accidental deletion) seems a little arbitrary. Really it seems like the components themselves should test for styles. Any thoughts on what's applicable here?
rusackas
reviewed
Apr 11, 2020
| ``` | ||
| const style = require('style'); | ||
|
|
||
| // TODO: DEMONSTRATE API |
There was a problem hiding this comment.
I can put together a little sample code for this if you want. Could poach an example from Tai's PR (using the package import, of course) , and add a link to the Emotion docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
🏠 Internal