Skip to content

Commit

Permalink
[SIX-278] feat & fix : 테스트 제외할 클래스 추가 및 버그 수정
Browse files Browse the repository at this point in the history
  • Loading branch information
heenahan committed Dec 13, 2023
1 parent 445a4b9 commit 77dd57c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
3 changes: 2 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ sonar {
property 'sonar.test.inclusions', '**/*Test.java'
property 'sonar.java.coveragePlugin', 'jacoco'
property 'sonar.exclusions', '''
**/Q*, **/request/*, **/response/*, **/dto/*, **/config/*, **/global/**, **/*Converter*, **/healthcheck/*
**/Q*, **/request/*, **/response/*, **/dto/*, **/config/*, **/global/**, **/*Converter*, **/healthcheck/*,
**/*Type*, **/*Mapper*, **/*EventListener*, **/kakao/*, **/*Dummy*, **/ErrorCode*
'''
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public Slice<MissionBookmarkMeQueryResponse> viewMyBookmarks(
.where(missionBookmark.userId.eq(userId))
.orderBy(mission.missionInfo.missionDate.asc(), mission.missionInfo.startTime.asc())
.offset(pageable.getOffset()) //TODO: 인덱스 및 NO-OFFSET 적용 고려
.limit(pageable.getPageSize() + 1)
.limit(pageable.getPageSize() + 1L)
.fetch();

return SliceResultConverter.consume(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public List<MissionQueryResponse> findByDynamicCondition(
regionIdsIn(request.regionIds()),
missionDatesIn(request.missionDates()))
.offset(pageable.getOffset())
.limit(pageable.getPageSize() + 1)
.limit(pageable.getPageSize() + 1L)
.orderBy(mission.createdAt.asc())
.fetch();
}
Expand Down Expand Up @@ -99,7 +99,7 @@ public List<MissionProgressQueryResponse> findProgressMissionByUserId(
.on(missionBookmark.mission.id.eq(mission.id), missionBookmark.userId.eq(userId))
.where(userIdEq(userId), missionStatusIsProgress())
.offset(pageable.getOffset())
.limit(pageable.getPageSize() + 1)
.limit(pageable.getPageSize() + 1L)
.orderBy(mission.createdAt.desc())
.fetch();
}
Expand Down Expand Up @@ -168,7 +168,7 @@ public List<MissionCompletedQueryResponse> findCompletedMissionByUserId(
.on(missionBookmark.mission.id.eq(mission.id), missionBookmark.userId.eq(userId))
.where(userIdEq(userId), missionStatusIsCompleted())
.offset(pageable.getOffset())
.limit(pageable.getPageSize() + 1)
.limit(pageable.getPageSize() + 1L)
.orderBy(mission.missionInfo.missionDate.desc())
.fetch();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public Slice<SentReviewQueryResponse> viewSentReviews(
.where(review.senderId.eq(userId))
.orderBy(review.createdAt.desc())
.offset(pageable.getOffset())
.limit(pageable.getPageSize() + 1)
.limit(pageable.getPageSize() + 1L)
.fetch();

return SliceResultConverter.consume(
Expand Down Expand Up @@ -86,7 +86,7 @@ public Slice<ReceivedReviewQueryResponse> viewReceivedReviews(
.where(review.receiverId.eq(userId))
.orderBy(review.createdAt.desc())
.offset(pageable.getOffset())
.limit(pageable.getPageSize() + 1)
.limit(pageable.getPageSize() + 1L)
.fetch();

return SliceResultConverter.consume(
Expand Down

0 comments on commit 77dd57c

Please sign in to comment.