Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIX-211] 유저 프로필 수정 API 로직 변경 & SSE 이벤트가 아닌 메시지로 전달 #121

Merged
merged 4 commits into from
Nov 28, 2023
Merged

[SIX-211] 유저 프로필 수정 API 로직 변경 & SSE 이벤트가 아닌 메시지로 전달 #121

merged 4 commits into from
Nov 28, 2023

Conversation

heenahan
Copy link
Collaborator

🖊️ 1. Changes

  • 유저 프로필 수정 API에서 기존 이미지를 삭제 그리고 새로운 이미지를 추가하는 로직으로 변경했습니다.
  • 유저 이미지 삭제 API는 제거하였습니다.
  • SSE 통신에서 이벤트가 아닌 메시지로 전달하도록 바꿨습니다.

🖼️ 2. Screenshot

❗️ 3. Issues

😌 4. To Reviewer

🙌 6. Checklist

  • - 통합 테스트를 수행해보셨나요?
  • - 혹시 컨벤션에 맞지 않게 작성하지 않았나요?
  • - Change와 Issue, Reviewer를 알아보기 쉽게 작성하였나요?

@heenahan heenahan self-assigned this Nov 28, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

Test Results

  61 files    61 suites   8s ⏱️
234 tests 232 ✔️ 2 💤 0 ❌
244 runs  242 ✔️ 2 💤 0 ❌

Results for commit d0715ab.

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug B 6 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 66 Code Smells

64.6% 64.6% Coverage
0.0% 0.0% Duplication

@heenahan heenahan merged commit d58534b into develop Nov 28, 2023
5 checks passed
@heenahan heenahan deleted the SIX-211 branch November 28, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legowww legowww Awaiting requested review from legowww

@bombo-dev bombo-dev Awaiting requested review from bombo-dev

Assignees

@heenahan heenahan

Labels
백엔드
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heenahan