Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIX-126] 불필요한 테스크 설정 제거 & Testcontainers로 mongodb 테스트 환경 구축 #133

Merged
merged 6 commits into from
Dec 27, 2023

Conversation

heenahan
Copy link
Collaborator

@heenahan heenahan commented Dec 13, 2023

🖊️ 1. Changes

  • sonar task에서 불필요한 설정 제거하였습니다.
  • mongodb 모듈에 Testcontainers로 테스트 환경 만들었습니다.

🖼️ 2. Screenshot

❗️ 3. Issues

😌 4. To Reviewer

🙌 6. Checklist

  • - 통합 테스트를 수행해보셨나요?
  • - 혹시 컨벤션에 맞지 않게 작성하지 않았나요?
  • - Change와 Issue, Reviewer를 알아보기 쉽게 작성하였나요?

@heenahan heenahan self-assigned this Dec 13, 2023
Copy link

github-actions bot commented Dec 13, 2023

Test Results

 68 files   68 suites   9s ⏱️
246 tests 245 ✅ 1 💤 0 ❌
256 runs  255 ✅ 1 💤 0 ❌

Results for commit e62cf1e.

♻️ This comment has been updated with latest results.

@heenahan heenahan changed the title [SiX-126] 불필요한 테스크 설정 제거 [SIX-126] 불필요한 테스크 설정 제거 Dec 26, 2023
@heenahan heenahan changed the title [SIX-126] 불필요한 테스크 설정 제거 [SIX-126] 불필요한 테스크 설정 제거 & Testcontainers로 mongodb 테스트 환경 구축 Dec 26, 2023
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

69 New issues
0 Security Hotspots
73.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@heenahan heenahan merged commit 9290d1d into develop Dec 27, 2023
4 checks passed
@heenahan heenahan deleted the SIX-126 branch December 27, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant