Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIX-22] 공통 응답 객체를 생성하는 기능 구현 #7

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

bombo-dev
Copy link
Member

@bombo-dev bombo-dev commented Oct 23, 2023

🖊️ 1. Changes

  • ErrorResponse에는 BindException 에서 발생하는 ValidationError를 가지고 있습니다. 해당 반환 값은 존재 할 시에만 Json으로 반환됩니다.
  • Exception 반환 시에는 기본적으로 기본 예외를 반환하도록 합니다. 그리고 Message에는 ErrorCode의 code명이 들어갑니다.
throw new RuntimeException(ErrorCode.E_001.name());
  • ApiResponse는 자주 사용하는 것에 대해서 설정하였고, Asia/Seoul 에서만 동작하기때문에 포맷팅을 따로 정하였습니다.

🖼️ 2. Screenshot

❗️ 3. Issues

😌 4. To Reviewer

✅ 5. Plans

  • - 프론트와 협의 후 컨펌이 되면 머지하도록 하겠습니다.

@bombo-dev bombo-dev requested review from legowww and heenahan October 23, 2023 07:56
@bombo-dev bombo-dev self-assigned this Oct 23, 2023
Copy link
Collaborator

@legowww legowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

Test Results

5 tests   5 ✔️  0s ⏱️
5 suites  0 💤
5 files    0

Results for commit 21d7cd1.

@bombo-dev bombo-dev merged commit 9ff58fb into develop Oct 23, 2023
@bombo-dev bombo-dev deleted the SIX-22 branch October 23, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants