Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underline prop to BranchName component #5577

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Jan 21, 2025

Adds the ability to have underlines in BranchName when being used as a link (<a>). The method to add underlines would be the same as in the Link component, and the same rules would apply in order for the underline to appear.

Context: https://github.com/github/accessibility-audits/issues/10090#issuecomment-2605230228

Changelog

New

  • Adds prop inline to BranchName component
  • Adds to documentation

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 2b5dadf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 21, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5577 January 21, 2025 18:32 Inactive
Copy link
Contributor

github-actions bot commented Jan 21, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.23 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 104.67 KB (+0.11% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5577 January 21, 2025 18:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant