Improved docker compose for tests #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does it improve? I can see config becoming more complicated, but I'm not sure there's much point in improving test performance on such a small library. |
|
I just spent 10 minutes to review my previous approach and change it. However, you can close the PR if you wish. |
|
Okay, have it your way. While you are at it, you could exclude docker files in .gitattributes. Thank you. |
nightio
force-pushed
the
improved-docker-compose
branch
from
e3f8e00 to
5ead9b3
Compare
|
Done. |
GromNaN
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.