Seperate attributes #348
Merged
Seperate attributes #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should do something similar to userInputs. Would make testing easier. |
fractalsbyx
force-pushed
the
seperate-attributes
branch
from
3dea5f7 to
4fb14f6
Compare
bugfix and number_of_variables replacement
mirrors recent bugfix on master as of 12/11/2024
fractalsbyx
force-pushed
the
seperate-attributes
branch
from
4fb14f6 to
5077e2f
Compare
landinjm
reviewed
Dec 12, 2024
landinjm
reviewed
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperate attributes from variableAttributeLoader.
Classes like MatrixFreePDE and such carry references to the attributes themselves rather than the loader, which just acts as a factory.
Also added nonlinearity criterion bugfix to this branch.
This may make unit testing easier.